On Tue, Jul 21, 2009 at 21:18, Peter Jones<pjones@xxxxxxxxxx> wrote:
> +static struct udev_device *handle_scsi_sas(struct udev_device *parent)> +{> + return NULL;> +}> +> +static struct udev_device *handle_scsi_iscsi(struct udev_device *parent)> +{> + return NULL;> +}> +
Why are you copying all the stuff, and not even the latest version, ifyou think that is useful?
> + subsys = udev_device_get_subsystem(parent);> +> + if (subsys == NULL) {> + ;> + } else if (strcmp(subsys, "scsi") == 0) {> + parent = handle_scsi(parent);> + } else if (strcmp(subsys, "cciss") == 0) {> + handle_cciss(parent);> + } else if (strcmp(subsys, "serio") == 0) {> + parent = skip_subsystem(parent, "serio");> + } else if (strcmp(subsys, "pci") == 0) {> + parent = skip_subsystem(parent, "pci");> + } else if (strcmp(subsys, "platform") == 0) {> + parent = skip_subsystem(parent, "platform");> + } else if (strcmp(subsys, "xen") == 0) {> + parent = skip_subsystem(parent, "xen");> + }> +> + parent = udev_device_get_parent(parent);> + }
What's the point of this loop? It does nothing but lookup the SCSIdevice which can be a single line, right?
Thanks,Kay��.n��������+%������w��{.n�����{��-�[��)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
