Re: scsi_id: correct error handling in prepend_vendor_model

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 6, 2009 at 15:54, Ian Campbell<Ian.Campbell@xxxxxxxxxx> wrote:
> The callers of prepend_vendor_model both expect < 0 to be returned on
> error and the index to be returned otherwise. However
> prepend_vendor_model actually returns 1 on error. Fix this by correctly
> returning -1.

Applied.

> (Although perhaps it would be better to log then return
> ind anyway so as to preserve some sort of backward compat?).

Let's see what goes wrong. It's a mess. One of the callers uses the
index and does not take into account, that it started at intdex 1, so
the last char gets always overwritten.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux