On Mon, 16 Mar 2009 22:53:22 +0100
Kay Sievers <kay.sievers@xxxxxxxx> wrote:
> On Mon, Mar 16, 2009 at 21:50, Robby Workman <rw@xxxxxxxxxxxxx> wrote:
>
> - " --type=
> type of events to trigger\n"
> + " --type=
> type of devices for events to trigger\n"
>
> "subsystems" are not "devices", they are the "class" or the "bus". I
> didn't know how to call them, so they just ended up being called
> "events" :)
Hrm, well, fair point; however, I just pulled that from the udevadm man
page:
--type=type
Trigger a specific type of devices. Valid types are:
devices, subsystems, failed. The default value is devices.
It seemed a bit questionable either way. For what it's worth, I didn't
even intend for that bit to be in the patch :)
> > I'm not sure it's a good idea to document "remove" here, or even if
> > it's valid (and I'm too chicken to find out) :-),
>
> + " --action=
> type of events to trigger\n"
> + " add|change|remove
> default is \"add\"\n"
>
> We could add them as examples, but the list is incomplete, and we
> should leave it to the kernel to finally define them. "add" and
> "change" as examples might make sense, if we think that belongs into
> the commandline output help.
Perhaps don't list examples then, but just note that the default is
"add" -- I guess it's not really a big deal one way or the other, but I
find it easier to run "udevadm trigger --help" instead of "man udevadm"
when I just need to remember the exact syntax, so the real goal here
was to add the "--action" to the help output.
-RW
Attachment:
signature.asc
Description: PGP signature
