On Fri, Jan 2, 2009 at 09:22, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: >> > I was playing a little bit with libudev and I actually need the DEVTYPE >> > from uevent for various tasks. Especially with USB and Bluetooth, the >> > subsystem value is too generic. >> > >> > Attached is a patch that implements udev_device_get_devtype() and also >> > udev_device_get_parent_with_devtype(). Please double check that I did it >> > the right way. >> >> Looks good. Applied. > > one minor thing that came to my mind is that DEVTYPE and subsystem are > actually kinda coupled. So a DEVTYPE="host" has a different semantic for > USB than for Bluetooth subsystem for example. Not sure if we actually > care or just add a udev_device_get_parent_with_subsystem_devtype() > function to give applications a choice if they wanna care. You mean replacing: udev_device_get_parent_with_devtype(..., *devtype) by: udev_device_get_parent_with_subsystem_devtype(..., *subsystem, *devtype) ? Sounds sensible, because in most cases you don't want to check for parents of a different subsystem. As you are using it, want to send a patch? Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
