-----BEGIN PGP SIGNED MESSAGE----- Hash: RIPEMD160 Kay Sievers wrote: > I'm pretty sure, that these values are always uppercase. Not sure why > the pnp bus uses tolower() for char 4-7 of the 8 byte array, that > looks pretty broken. Hmm. Sounds like pnp might need a fix then? Or whatever. > That looks like the right fix. Maybe you could use strdup()? I could (and that was what I did at first). Then I figured, since I'm going through every byte anyway, why not copy and uppercase at the same time. A naive strdup (malloc plus copy each byte), plus this loop to convert, would take longer to run than just a malloc and this loop. However, it's not like this code is a large chunk of a kernel compile, either; I'm guessing strdup is more readable, so that's fine too. Doesn't really matter to me. > Care to send it to lkml and Cc: Greg, so he can pick it up? I can, but it will be a while. (I'm about to take ~2 weeks off starting Tuesday and fly back across a continent for the upcoming holidays. It will be hard to keep up on something like that while I'm out, so I'll probably just wait until I get back.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEAREDAAYFAklPLjIACgkQYasYN+YI5W5g+ACeNCOyTmBcfASseCRfDnWMCxt+ NvMAnR7dLKAsqIXGIctjUuU4uBkxj/Cl =3JZI -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
