On Tue, Dec 9, 2008 at 04:07, Ryan Thomas <ryan@xxxxxxxxxx> wrote: > Kay Sievers wrote: >> On Tue, Dec 9, 2008 at 01:49, Marco d'Itri <md@xxxxxxxx> wrote: >>> On Dec 09, Ryan Thomas <ryan@xxxxxxxxxx> wrote: >>> >>>> In the interest of standardizing udev rules, please consider the >>>> following patch that adds udev rules for the ATA over Ethernet character >>>> and block devices. The aoe module has been a long-time member of the >>>> kernel and needs inclusion in the standard udev rules. >>> >>> Debian so far has used these rules which are more generic and much >>> simpler. Are they incorrect in some way? >>> >>> # AOE character devices >>> SUBSYSTEM=="aoe", NAME="etherd/%k" >>> >>> SUBSYSTEM=="aoe", MODE="0220", GROUP="disk" >>> SUBSYSTEM=="aoe", KERNEL=="err", MODE="0440", GROUP="disk" >> >> That looks fine. >> >> I wonder why we have this comment: >> +# aoe block devices >> +SUBSYSTEM=="aoe", KERNEL=="etherd*", NAME="%k", GROUP="disk" >> >> They can not be block devices if they have SUBSYSTEM=="aoe". Do the >> etherd* devices belong into the subdir or not? >> >> We have: >> SUBSYSTEM=="aoe", NAME="etherd/%k", GROUP="disk" >> in the current default rules. >> >> I guess doing: >> # ATA over Ethernet >> SUBSYSTEM=="aoe", NAME="etherd/%k", GROUP="disk", MODE="0220" >> SUBSYSTEM=="aoe", KERNEL=="err", MODE="0440" >> would be all we need. > My previous patch should be backed out as you are right that it's not > needed. > > A patch to the default rules to correct the mode on the etherd/err character > device is all that is needed. Applied. Please check: http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=2fc635fb67dbd509f4ee532c8bf0d3885cc71989 The block device are never moved to the subdir, they all just stay in /dev, right? Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
