Re: [PATCH] threadsafe rules iteration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Jenkins wrote:
> Move ->current out of struct udev_rules and into a new struct udev_rules_iter.
>
> Signed-off-by: Alan Jenkins <alan-jenkins@xxxxxxxxxxxxxx>
>
> diff --git a/udev/udev_rules.c b/udev/udev_rules.c
> index da7a62a..c21d762 100644
> --- a/udev/udev_rules.c
> +++ b/udev/udev_rules.c
>   

> @@ -1561,14 +1562,15 @@ int udev_rules_get_name(struct udev_rules *rules, struct udevice *udev)
>  
>  int udev_rules_get_run(struct udev_rules *rules, struct udevice *udev)
>  {
> +	struct udev_rules_iter *iter;
>   

Sorry, don't apply that.  It should be

	struct udev_rules_iter iter;


I think we should be building with -Werror, but I'm not sure how to tell
autoconf/automake.

udev_rules.c: In function ‘udev_rules_get_run’:
udev_rules.c:1571: warning: passing argument 1 of ‘udev_rules_iter_init’
from incompatible pointer type
udev_rules.c:1573: warning: passing argument 1 of ‘udev_rules_iter_next’
from incompatible pointer type
udev_rules.c:1624: warning: passing argument 1 of
‘udev_rules_iter_label’ from incompatible pointer type


--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux