Hi Benjamin,
thanks for the feedback!
>On Thu, 2024-08-29 at 08:01 +0000, Cermak Dominik wrote:
>> Extending commit f136837202393a7e1f3182e9efdbf1aaa0c1a5c2.
>
>Usually the format used is
> commit <12 sha1 characters> ("message")
>which would at least give the first line/subject of the commit message.
>
>In this case, a little bit more context is probably a good idea,
>especially if you reference it later using "still".
Here is my try at improving the commit message:
"
We got connection failures because of outdated channel information.
That's because the NL80211_CMD_REG_CHANGE event is important for all
interfaces.
Commit f13683720239 ("nl80211: Pass wiphy events to all affected
interfaces") skips the early termination for events directed to a wiphy,
but that doesn't cover the regulatory change event because it doesn't
have a wiphy set either.
Therefore the early termination still kicks in and from three
interfaces, only one got the updated channel list.
Fix this by changing the early termination logic to only apply to events
directed either to a specific interface index for wdev.
"
What do you think? Does it cover your concerns about context?
Best regards
Dominik Cermak | Software Engineer
______________________________________________
JOYNEXT GmbH
Gewerbepark Merbitz 5, 01156 Dresden / Germany
Tel +49 351 45355-6385, Fax +49 351 45355 40
Dominik.Cermak@xxxxxxxxxxx, www.joynext.com
For legal and security reasons the information provided in this e-mail is not legally binding. Upon request we would be pleased to provide
you with a legally binding confirmation in written form. Any form of unauthorised use, publication, reproduction, copying or disclosure
of the content of this e-mail is not permitted. This message is exclusively for the person addressed or their representative. If you are
not the intended recipient of this message and its contents, please notify the sender immediately.
JOYNEXT GmbH; Geschäftsführung: Stavros Mitrakis (Vors.), Dr. Holger Buchner;
Gesellschaft mit beschränkter Haftung mit Sitz in Dresden; Amtsgericht Dresden HRB 657; USt.-IdNr.: DE 140 212 281
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
