On Tue, Apr 09, 2024 at 07:44:03AM +0000, Nikita Chernikov wrote: > Currently, RNR elements built from nr_db are only advertised in beacon. > To comply with 11AX standard, RNR IE of 6G should also be advertised in probe response. Could you please be more specific on what exact requirements you are referring to? The one in IEEE Std 80211ax-2021, 11.53 about RNR element with the Co-Located AP subfield being set to 1? If so, that is conditional on the AP operating in the 2.4 GHz or 5 GHz and being in the same co-located AP set as the 6 GHz AP. Those conditions should likely be included here as well. > Also, replace magic numbers with definitions in nr_db RNR element construction. That should be in a separate patch of its own to make the actual functional changes clearer. > diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c > + /* Skip building RNR element from nr_db for non 6G VAPs in probe response */ > + if (!(is_6ghz_op_class(wpabuf_head_u8(nr->nr)[HOSTAPD_NEIGHBOR_DB_NR_OPCLASS])) && > + (frame_stype == WLAN_FC_STYPE_PROBE_RESP)) > continue; It looks quite strange to look at the RNR information for determining whether the AP is operating on the 6 GHz band. Shouldn't this be based on the local AP's configuration, i.e., hapd->iconf->op_class? -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
