From: Sriram R <quic_srirrama@xxxxxxxxxxx> hostapd_eapol_tx_status() function is being used only at one place in drv_callbacks. However, it is defined in ieee802_11.c which does not suit there. Hence, being the function definition in drv_callbacks.c and make it static. No functionality changes. Signed-off-by: Sriram R <quic_srirrama@xxxxxxxxxxx> Signed-off-by: Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx> --- src/ap/drv_callbacks.c | 25 +++++++++++++++++++++++++ src/ap/ieee802_11.c | 28 ---------------------------- src/ap/ieee802_11.h | 2 -- 3 files changed, 25 insertions(+), 30 deletions(-) diff --git a/src/ap/drv_callbacks.c b/src/ap/drv_callbacks.c index 3b24aa4f442a..12e6b3f361fc 100644 --- a/src/ap/drv_callbacks.c +++ b/src/ap/drv_callbacks.c @@ -2348,6 +2348,31 @@ err: } #endif /* CONFIG_OWE */ +static void hostapd_eapol_tx_status(struct hostapd_data *hapd, const u8 *dst, + const u8 *data, size_t len, int ack) +{ + struct sta_info *sta; + struct hostapd_iface *iface = hapd->iface; + + sta = ap_get_sta(hapd, dst); + if (sta == NULL && iface->num_bss > 1) { + size_t j; + for (j = 0; j < iface->num_bss; j++) { + hapd = iface->bss[j]; + sta = ap_get_sta(hapd, dst); + if (sta) + break; + } + } + if (sta == NULL || !(sta->flags & WLAN_STA_ASSOC)) { + wpa_printf(MSG_DEBUG, "Ignore TX status for Data frame to STA " + MACSTR " that is not currently associated", + MAC2STR(dst)); + return; + } + + ieee802_1x_eapol_tx_status(hapd, sta, data, len, ack); +} void wpa_supplicant_event(void *ctx, enum wpa_event_type event, union wpa_event_data *data) diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index 26e3d8356bb6..9f7e9afdd177 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -6874,34 +6874,6 @@ void hostapd_tx_status(struct hostapd_data *hapd, const u8 *addr, ieee802_1x_tx_status(hapd, sta, buf, len, ack); } - -void hostapd_eapol_tx_status(struct hostapd_data *hapd, const u8 *dst, - const u8 *data, size_t len, int ack) -{ - struct sta_info *sta; - struct hostapd_iface *iface = hapd->iface; - - sta = ap_get_sta(hapd, dst); - if (sta == NULL && iface->num_bss > 1) { - size_t j; - for (j = 0; j < iface->num_bss; j++) { - hapd = iface->bss[j]; - sta = ap_get_sta(hapd, dst); - if (sta) - break; - } - } - if (sta == NULL || !(sta->flags & WLAN_STA_ASSOC)) { - wpa_printf(MSG_DEBUG, "Ignore TX status for Data frame to STA " - MACSTR " that is not currently associated", - MAC2STR(dst)); - return; - } - - ieee802_1x_eapol_tx_status(hapd, sta, data, len, ack); -} - - void hostapd_client_poll_ok(struct hostapd_data *hapd, const u8 *addr) { struct sta_info *sta; diff --git a/src/ap/ieee802_11.h b/src/ap/ieee802_11.h index a35486d46406..262e0ce14ab4 100644 --- a/src/ap/ieee802_11.h +++ b/src/ap/ieee802_11.h @@ -132,8 +132,6 @@ int hostapd_get_he_twt_responder(struct hostapd_data *hapd, u8 * hostapd_eid_cca(struct hostapd_data *hapd, u8 *eid); void hostapd_tx_status(struct hostapd_data *hapd, const u8 *addr, const u8 *buf, size_t len, int ack); -void hostapd_eapol_tx_status(struct hostapd_data *hapd, const u8 *dst, - const u8 *data, size_t len, int ack); void ieee802_11_rx_from_unknown(struct hostapd_data *hapd, const u8 *src, int wds); u8 * hostapd_eid_assoc_comeback_time(struct hostapd_data *hapd, -- 2.25.1 _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap