Re: [PATCH] Fix the wrapping of dBus container for SignalPoll

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the information!
https://w1.fi/wpa_supplicant/devel/dbus.html shows SignalPoll returns
a{sv} properties, while the code wraps the dict as a variant, which
causes implicit unwrapping in our code.
Similar wrapping is also seen in other places such as
wpas_dbus_simple_array_property_getter(), wpas_dbus_getter_bss_wps(),
wpas_dbus_getter_network_properties(). If we want to maintain this
behavior for compatibility or whatever reason, we might update the
documentation to clarify that it is WAI, otherwise I can submit
another patch to remove all these variant wrappings.

Best regards
Kaidong

On Sat, Jan 20, 2024 at 10:13 AM Jouni Malinen <j@xxxxx> wrote:
>
> On Thu, Jan 18, 2024 at 11:16:06AM -0800, Kaidong Wang wrote:
> > This patch removes the wrapping of variants for SignalPoll, but I saw
> > this wrapping also used for all dict containers. Is this wrapping
> > expected?
>
> I have to admit that I do not know why that design was used, but it was
> present from the very first commit that added the new DBus API in 2009..
>
> --
> Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux