On Wed, Dec 20, 2023 at 08:23:09PM +0000, Matthew Wang wrote: > Hide ChromeOS specific code behind a flag. > diff --git a/wpa_supplicant/Makefile b/wpa_supplicant/Makefile > @@ -491,6 +491,10 @@ else > +ifdef CONFIG_CHROMIUM > +CFLAGS += -DCHROMIUM > +endif I would need to have some more details on how this flag might be used in the future to be able to determine whether this is a reasonable approach. As an example, if you just need to define CHROMIUM and this would not have impact to how the Makefile is used (e.g., selectively adding some source code files), it would be simpler to just add "CFLAGS += -DCHROMIUM" into wpa_supplicant/.config used in the builds than make this go through the Makefile. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
