On Wed, Nov 08, 2023 at 06:26:09PM +0530, Vinayak Yadawad wrote: > This patch adds support for AP/P2P GO 4way HS support. > For drivers supporting the AP PSK offload, supplicant/hostapd > would pass down the PSK for driver to handle 4way handshake. > The driver is expected to indicate PORT authorized event to > indicate that the 4way handshake is completed successfully. Thanks, applied with some fixes and cleanup. This broke hundreds of hwsim test cases due to incorrect AP mode configuration and kernel rejecting to start the AP because of that. I cleaned up the way the PSK is set, or more importantly, not set in some cases. What happens when this offload is used and a station request rekeying with EAPOL-Key Request frame? Will the driver/firmware take care of deriving a new PTK? What about GTK updates? Will those be handled in driver/firmware as well? Would hostapd need some additional checks to avoid periodic GTK rekeying or configuration that would result in trying to do that? -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap