On Tue, Nov 07, 2023 at 01:30:57PM +0100, Andrzej Ostruszka wrote: > Overwriting of SSID for the hidden OWE BSS entry has some side effects: > - first the entry is notified over DBus with empty SSID and the update > of SSID is never signaled (it is not even possible at the moment to > notify the SSID change - see wpas_dbus_bss_signal_prop_changed()), > - during (and after) association there will be multiple entries > referring to the same BSSID/SSID pair, > - during association we look for the relevant BSS by BSSID but there are > multiple entries with the same BSSID and SSID and supplicant can > choose entry that was initially signaled with empty SSID. > > To address this two changes are made: > 1. Stop overwriting SSID. Thanks, I applied this part. > 2. When selecting the BSS entry for CurrentBSS property prefer ones that > have non-empty SSID. And as noted in the previous email, I addressed this differently: https://w1.fi/cgit/hostap/commit/?id=5b12a055908ba07a57c7805d412fa7e69ab8b108 To avoid regressions with unnecessary scanning of all channels multiple times, this commit is needed as well: https://w1.fi/cgit/hostap/commit/?id=9c97126576b7dfa84731aec3d2a54f9195da1cfe And the changes here to owe_trans_ssid() make one more area completely useless, so I removed that as well: https://w1.fi/cgit/hostap/commit/?id=93a68a1fc9bcc41d8a9f3dc4a651f54b02092bc7 -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
