On Tue, Oct 10, 2023, at 09:39, Jouni Malinen wrote: > On Thu, May 04, 2023 at 02:00:31PM +1200, Gilad Itzkovitch wrote: >> This commit adds support for specifying a frequency in khz. The >> predominate use case is S1G. Many S1G channels are centered on frequencies >> which a MHz value does not support. Additional freq_khz parameters have >> been added as required to the key structures that maintain the operating >> parameters of a hostapd AP. These freq_khz params have been added to key >> functions alongside the traditional freq parameter as an alternative. >> >> The extent of this commit is the support of core BSS functionality using >> freq_khz. It is intended that several follow up commits will make use of >> this concept to support more advanced features. >> >> Because this commit has introduced an alternative parameter that is used >> instead of the traditional freq param we needed to introduce logic that >> would support this change. We opted for logic that checks if freq_khz is >> set, and if so, uses that parameter going forward, otherwise if freq_khz >> is not set, freq is used as per the existing use case. >> This approach prevents regression for existing code. >> >> The kernel maintains frequencies by using a combination of freq and >> freq_offset parameters. This patch includes a number of changes to support >> this concept. > > This patch on its own does not seem to enable additional functionality, > so it is a bit difficult to review this from the view point of how > appropriate this is for full S1G support. > > Is there a publicly available set of patches that would enable S1G > support to the point of being able to use it with mac80211_hwsim in both > AP and STA modes to complete successful authentication? These may help, though I haven't been looking at S1G in a while. https://github.com/twpedersen/hostap https://github.com/twpedersen/linux https://github.com/twpedersen/iw > While I would obviously prefer to apply smaller patches as separate > individual commits, I would like to be able to do that while reviewing a > set of patches that would result in something more meaningful getting > added once the full set is applied. Ideally, this would be something > that would allow at least some minimal testing to be done with > mac80211_hwsim. > > -- > Jouni Malinen PGP id EFC895FA > > _______________________________________________ > Hostap mailing list > Hostap@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/hostap -- thomas _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
