Thanks for the review! On 12/2/22 14:08, Jouni Malinen wrote:
I'm fine with doing this kind of things for testing purposes under the CONFIG_TESTING_OPTIONS build parameter, but providing a mechanism for sending practically any kind of Action frame in a production build feels problematic. There might be somewhat reduced privilege requirements for the hostapd control interfaces compared to being able to use NL80211_CMD_FRAME directly.
Indeed, it makes sense.. In our case we needed it outside CONFIG_TESTING_OPTIONS, so I'll abandon this approach.
In addition, sending some Action frames without hostapd having the internal context on the state can result in unexpected behavior when processing either the TX status callback or a response from a STA to such an Action frame.
In our case we need to be able to send a DELBA frame to a station at an arbitrary point in time (the point is to tear down any existing block ack agreement for a very short period of time - on kernels that don't support NL80211_TID_CONFIG_ATTR_AMPDU_CTRL yet). Would a new command to send a DELBA frame to a specific station have more chances to be accepted? Kind regards, Raphaël _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
