Re: [PATCH v2 07/15] SME: Add support for handling authentication with MLD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 11/30/2022 6:39 PM, Andrei Otcheretianski wrote:

snip

+	wpa_s->mld = 1;
+	wpa_s->valid_links = BIT(wpa_s->mlo_assoc_link_id);

Can "valid_links" itself be used with non-zero check instead of additional variable "mld"?

+
+	rnr_ie = wpa_bss_get_ie(bss, WLAN_EID_REDUCED_NEIGHBOR_REPORT);
+	if (!rnr_ie) {
+		wpa_dbg(wpa_s, MSG_DEBUG, "MLD: no RNR element");
+		ret = true;
+		goto out;
+	}
snip
+			struct wpa_bss *neigh_bss =
+				wpa_bss_get_bssid(wpa_s, ap_info->data + 1);
+			u8 link_id = *(data + 1) & 0xF;
+
+			if (neigh_bss) {
+				wpa_s->valid_links |= BIT(link_id);
+				os_memcpy(wpa_s->links[link_id].bssid,
+					  ap_info->data + 1, ETH_ALEN);
+				wpa_s->links[link_id].freq =
+					neigh_bss->freq;
we need to add checks for local device capabilities before deciding any specific link should be considered for MLO association or not, right?
+			} else {
+				wpa_printf(MSG_DEBUG,
+					   "MLD: neighbor not found in scan");
+			}
+		}

Thanks,

Veeru


_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux