On Mon, Sep 26, 2022 at 04:37:24PM -0700, Mahesh Patil wrote: > This is based on driver_wired.c and provides driver interface for the > NVIDIA MACSec Driver. > diff --git a/src/drivers/driver.h b/src/drivers/driver.h > /* driver_macsec_linux.c */ > extern const struct wpa_driver_ops wpa_driver_macsec_linux_ops; > #endif /* CONFIG_DRIVER_MACSEC_LINUX */ > +#ifdef CONFIG_DRIVER_NVMACSEC_LINUX > +/* driver_macsec_nv.c */ > +extern const struct wpa_driver_ops wpa_driver_macsec_nv_ops; > +#endif /* CONFIG_DRIVER_NVMACSEC_LINUX */ This should be CONFIG_DRIVER_MACSEC_NV to be consistent with the previously used build defines. > diff --git a/src/drivers/driver_macsec_nv.c b/src/drivers/driver_macsec_nv.c > + * hostapd / Driver interaction with NVIDIA macsec driver Is this specific to only hostapd side? Or would this work with wpa_supplicant as well? > +#include <macsec_client.h> What is that header file and where does one get it? I was not able to compile this because of that file missing and if this line is commented out, there were undefined structures and I could not find definitions for those anywhere. PS. It is somewhat inconvenient if there is a large number of incompatible kernel interfaces for setting up similar functionality. Is there a good reason for not trying to use the upstream kernel interface for MACsec and extend it as needed? -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
