"Remove a host of unnecessary OPENSSL_IS_BORINGSSL ifdefs" breaks build on older OSs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello David,

This patch is breaking compile on Fedora-24 and earlier (due to older openssl).

Does this patch actually help anything, or is it just code cleanup?

commit faf9c04cb51c9c1b5f2a4599c57e6ba44f6d2428
Author: David Benjamin <davidben@xxxxxxxxxx>
Date:   Mon Jun 13 12:22:05 2022 -0400

    Remove a host of unnecessary OPENSSL_IS_BORINGSSL ifdefs

    The <openssl/buf.h> include is relevant in both OpenSSL and BoringSSL
    because the file uses BUF_MEM (include what you use). OpenSSL just
    happened to include it via another file. OpenSSL also spells it
    <openssl/buffer.h>, not matching the type, so use the compatible
    spelling.

    Additionally all the CHECKED_CAST and manual STACK_OF(T) definitions
    call into BoringSSL internals. The correct, public APIs are simply to
    just use the same code as OpenSSL and call the DEFINE_STACK_OF macros.

    Signed-off-by: David Benjamin <davidben@xxxxxxxxxx>

Thanks,
Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux