On Wed, Oct 19, 2022 at 07:43:55PM +0530, Veerendranath Jakkam wrote:
> Add support to print MLO link ID in hexdump debug prints.
> diff --git a/src/utils/wpa_debug.h b/src/utils/wpa_debug.h
> +void wpa_hexdump_link(int level, u8 link_id, const char *title, const void *buf,
> + size_t len);
> +void wpa_hexdump_link_key(int level, u8 link_id, const char *title,
> + const void *buf, size_t len);
These feel excessively specific for a generic debug print interface. I
don't think wpa_debug.c/h should really need to know anything about MLO.
Maybe a helper function in src/rsn_supp/wpa.c for using the existing
wpa_hexdump{,_key} and using dynamic printing of the title text to
include the Link ID would be more appropriate.
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
