Re: [PATCH] dbus: Fix property DebugShowKeys and DebugTimestamp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 05, 2022 at 01:11:28PM +0200, Clemens Famulla-Conrad wrote:
> It is possible to specify -t or -K multiple times. With this the
> value isn't boolean anymore and we hit a assert in libdbus
> function `dbus_message_iter_append_basic()`, which expect 0 or 1
> for DBUS_TYPE_BOOLEAN.

Thanks, applied with a copy-paste bug fixed:

> @@ -927,8 +929,10 @@ dbus_bool_t wpas_dbus_getter_debug_show_keys(
>  {
> +	dbus_bool_t b = wpa_debug_timestamp ? TRUE : FALSE;
> +
>  	return wpas_dbus_simple_property_getter(iter, DBUS_TYPE_BOOLEAN,
> -						&wpa_debug_show_keys, error);
> +						&b, error);

That should clearly have used wpa_debug_show_keys as the source
information here.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux