Hi, > -----Original Message----- > From: Jouni Malinen <j@xxxxx> > Sent: Saturday, May 07, 2022 21:15 > To: Peer, Ilan <ilan.peer@xxxxxxxxx> > Cc: hostap@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v5 4/4] P2P: Do not use collocated scan logic when > scanning 6GHz > > On Sun, Apr 24, 2022 at 12:57:55PM +0300, Ilan Peer wrote: > > Passively scan 6GHz channels during P2P find full scan as P2P GOs are > > not expected to be published in RNR or other APs on the 2GHz and 5GHz > > bands. > > > diff --git a/wpa_supplicant/p2p_supplicant.c > > b/wpa_supplicant/p2p_supplicant.c @@ -444,8 +444,16 @@ static int > wpas_p2p_scan(void *ctx, enum p2p_scan_type type, int freq, > > - if (!wpa_s->conf->p2p_6ghz_disable) > > + if (!wpa_s->conf->p2p_6ghz_disable) { > > params->p2p_include_6ghz = include_6ghz; > > + > > + /* > > + * passively scan non PSC channels without relying on > collocated > > + * logic > > + */ > > + params->non_coloc_6ghz = include_6ghz; > > + } > > This sounds very incorrect. Why would a P2P device scan for non-PSC > channels on the 6 GHz band? The P2P GO would be a 6 GHz-only AP and as > such, such set the primary 20 MHz to coincide with a PSC based on IEEE Std > 802.11ax-2021 expectations. > This handles the case that non-PSC channels are included in the scan request. If they are not included this setting does not have any effect. Note that currently if the 'p2p_include_6ghz' is set in the scan parameters and no frequencies are configured in the scan parameters then all channels would be scanned, which would include the non-PSC channels in case the drivers supports them. As noted previously, we can change this behavior to only include PSC channels if 'p2p_include_6ghz' channels Is set. Would you like such a change? Regards, Ilan. _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap