[PATCH] MKA: Peer message number updated twice

[Greg Goblirsch <gregg@xxxxxxxxxxxxxxxx>]

The peer message number is first updated in ieee802_1x_mka_decode_basic_body. It checks that the new number is greater. The second update is in ieee802_1x_mka_decode_live_peer_body. There is no check.

Signed-off-by: Greg Goblirsch <gregg@xxxxxxxxxxxxxxxx>

@@ -1159,10 +1185,9 @@ static int ieee802_1x_mka_decode_live_peer_body(
                        continue;
 
                peer = ieee802_1x_kay_get_peer(participant, peer_mi->mi);
-               if (peer) {
-                       peer->mn = peer_mn;
-               } else if (!ieee802_1x_kay_create_potential_peer(
-                               participant, peer_mi->mi, peer_mn)) {
+               if (!peer) {
+                       if (!ieee802_1x_kay_create_potential_peer(
+                               participant, peer_mi->mi, peer_mn))
                        return -1;
                }
        }

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap