On Sun Apr 17, 2022 at 11:18 AM CEST, Jouni Malinen wrote: > Why is this removing the use of WPA_DRIVER_FLAGS_DFS_OFFLOAD completely > here? I'm not completely sure I understood what kind of a case could > have allowed ACS to select a DFS channel incorrectly. Maybe that is > something that should be addressed in the ACS implementation instead? > > Please note that the DFS offload cases might use different style for > configuring the DFS operations, so it is not clear whether the > ieee80211h parameter is really applicable in all such cases and this > type of a change could result in breaking something that is already > deployed. So this code fetches the channels supported by the hardware and applies flags on it depending on whether or not we can use them and under what conditions. So for a regular driver (one that does not sets the WPA_DRIVER_FLAGS_DFS_OFFLOAD flag), when DFS is disabled by hostapd conf, any DFS channel will be flagged as disabled. This gets bypassed when the driver sets WPA_DRIVER_FLAGS_DFS_OFFLOAD.
