On Sat, Apr 16, 2022 at 07:18:08AM -0700, Ben Greear wrote: > The mt7915 driver mistakenly enables this feature for mt7915 radios from > asia-rf that do not have the hardware support for this feature. Has that been fixed in the driver already or is this a known, but not fixed issue in an actually released kernel version? > And there is very little complexity added by my patch. There are often > unforseen bugs in new features, I think it is good practice to allow > them to be disabled. Every new configuration parameter makes things more complex. I don't know how a normal user could easily figure out when to disable this particular feature as an example. I don't think I would agree with it being a good practice to provide an explicit user configuration parameter for all new features. In fact, I'd highly prefer not to have to do that for any new feature without a good justification. Whether this particular case is a good justification depends on whether that identified driver issue has made its way into commonly used kernel releases. The most appropriate fix for this would obviously be to fix the driver instead of providing user space workarounds that users would need to manually figure out when to use. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
