On Wed, 2021-11-03 at 21:08 +0200, Jouni Malinen wrote:
> On Wed, Sep 08, 2021 at 05:18:51PM +0800, Ryder Lee wrote:
> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> > diff --git a/src/ap/beacon.c b/src/ap/beacon.c
> > @@ -578,11 +578,17 @@ static u8 * hostapd_gen_probe_resp(struct
> > hostapd_data *hapd,
> > #ifdef CONFIG_IEEE80211AX
> > if (hapd->iconf->ieee80211ax && !hapd->conf->disable_11ax) {
> > + u8 *cca_pos;
> > +
> > pos = hostapd_eid_he_capab(hapd, pos,
> > IEEE80211_MODE_AP);
> > pos = hostapd_eid_he_operation(hapd, pos);
> > pos = hostapd_eid_spatial_reuse(hapd, pos);
> > pos = hostapd_eid_he_mu_edca_parameter_set(hapd, pos);
> > pos = hostapd_eid_he_6ghz_band_cap(hapd, pos);
> > + cca_pos = hostapd_eid_cca(hapd, pos);
>
> The BSS Color Change Announcement element is supposed to be between
> the
> HE Operation and the Spatial Reuse Parameter Set elements, i.e., a
> couple of lines above here..
>
> > @@ -1567,12 +1573,18 @@ int ieee802_11_build_ap_params(struct
> > hostapd_data *hapd,
> > #ifdef CONFIG_IEEE80211AX
> > if (hapd->iconf->ieee80211ax && !hapd->conf->disable_11ax) {
> > + u8 *cca_pos;
> > +
> > tailpos = hostapd_eid_he_capab(hapd, tailpos,
> > IEEE80211_MODE_AP);
> > tailpos = hostapd_eid_he_operation(hapd, tailpos);
> > tailpos = hostapd_eid_spatial_reuse(hapd, tailpos);
> > tailpos = hostapd_eid_he_mu_edca_parameter_set(hapd,
> > tailpos);
> > tailpos = hostapd_eid_he_6ghz_band_cap(hapd, tailpos);
> > + cca_pos = hostapd_eid_cca(hapd, tailpos);
>
> Same here.
>
> What about the (Re)Association Response frames? Should we add the BSS
> Color Change Announcement element to them as well?
Yes, we need to add it into assoc frames to prevent corner cases
regarding color missmatching during connection. So far, we only reuse
CSA counter attributes to implement the CCA part in kernel side, but we
plan to add an assoc attribute. It will take some time to do it, so I
think we can get the basic part accepted by hostap first and an
incremental patch afterwards. What do you think?
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
