From: Ilan Peer <ilan.peer@xxxxxxxxx> As the bit positions were used to set the bits instead of using shift operations. In addition the capability bits should not be shifted as the shifting is handled later. Signed-off-by: Ilan Peer <ilan.peer@xxxxxxxxx> Signed-off-by: Andrei Otcheretianski <andrei.otcheretianski@xxxxxxxxx> --- src/ap/ieee802_11_shared.c | 6 +++--- wpa_supplicant/pasn_supplicant.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/ap/ieee802_11_shared.c b/src/ap/ieee802_11_shared.c index 045310594b..a429b5dd48 100644 --- a/src/ap/ieee802_11_shared.c +++ b/src/ap/ieee802_11_shared.c @@ -1122,11 +1122,11 @@ u8 * hostapd_eid_rsnxe(struct hostapd_data *hapd, u8 *eid, size_t len) } if (hapd->iface->drv_flags2 & WPA_DRIVER_FLAGS2_SEC_LTF) - capab |= BIT(WLAN_RSNX_CAPAB_SECURE_LTF - 8); + capab |= BIT(WLAN_RSNX_CAPAB_SECURE_LTF); if (hapd->iface->drv_flags2 & WPA_DRIVER_FLAGS2_SEC_RTT) - capab |= BIT(WLAN_RSNX_CAPAB_SECURE_RTT - 8); + capab |= BIT(WLAN_RSNX_CAPAB_SECURE_RTT); if (hapd->iface->drv_flags2 & WPA_DRIVER_FLAGS2_PROT_RANGE_NEG) - capab |= BIT(WLAN_RSNX_CAPAB_PROT_RANGE_NEG - 8); + capab |= BIT(WLAN_RSNX_CAPAB_PROT_RANGE_NEG); flen = (capab & 0xff00) ? 2 : 1; if (len < 2 + flen || !capab) diff --git a/wpa_supplicant/pasn_supplicant.c b/wpa_supplicant/pasn_supplicant.c index 736a6c7d6f..4f5ac589b9 100644 --- a/wpa_supplicant/pasn_supplicant.c +++ b/wpa_supplicant/pasn_supplicant.c @@ -689,11 +689,11 @@ static struct wpabuf * wpas_pasn_build_auth_1(struct wpa_supplicant *wpa_s) /* TODO: How to handle protected TWT and SAE H2E? */ capab = 0; if (wpa_s->drv_flags2 & WPA_DRIVER_FLAGS2_SEC_LTF) - capab |= WLAN_RSNX_CAPAB_SECURE_LTF; + capab |= BIT(WLAN_RSNX_CAPAB_SECURE_LTF); if (wpa_s->drv_flags2 & WPA_DRIVER_FLAGS2_SEC_RTT) - capab |= WLAN_RSNX_CAPAB_SECURE_RTT; + capab |= BIT(WLAN_RSNX_CAPAB_SECURE_RTT); if (wpa_s->drv_flags2 & WPA_DRIVER_FLAGS2_PROT_RANGE_NEG) - capab |= WLAN_RSNX_CAPAB_PROT_RANGE_NEG; + capab |= BIT(WLAN_RSNX_CAPAB_PROT_RANGE_NEG); wpa_pasn_add_rsnxe(buf, capab); ret = pasn_auth_frame_hash(pasn->akmp, pasn->cipher, -- 2.28.0 _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap