Nice first post! A tip or two:
On Mon, Nov 2, 2020 at 5:12 PM Arowa Suliman <arowa@xxxxxxxxxxxx> wrote:
>
> wpa_supplicant does not send a D-Bus notification of the BSS frequency
> change when a CSA happens. Sending a PropertyChanged signal with the
> updated frequency will notify the network manager quickly, instead of
> waiting for the next scan results.
>
> Signed-off-by: Arowa Suliman <arowa@xxxxxxxxxxxx>
> Change-Id: Ic68964d505e4d97334502f1a638394bc57291be3
You carried the "Change-Id" field here, which comes from a Gerrit
instance that Jouni probably doesn't care about. Normally, I might
expect to see those kind of things removed when submitting here. ("git
log --grep=Change-Id" shows that there's only one instance of an
accidental "Change-Id" in the upstream git logs.)
> ---
> ...cant-Notify-freq-change-on-CH_SWITCH.patch | 108 ++++++++++++++++++
^^ You should remove this; there's no need to check a version of the
patch file into the git repository ;)
> wpa_supplicant/bss.c | 16 +--
> wpa_supplicant/bss.h | 18 +++
> wpa_supplicant/events.c | 6 +
> 4 files changed, 134 insertions(+), 14 deletions(-)
> create mode 100644 0001-wpa_supplicant-Notify-freq-change-on-CH_SWITCH.patch
>
> diff --git a/0001-wpa_supplicant-Notify-freq-change-on-CH_SWITCH.patch b/0001-wpa_supplicant-Notify-freq-change-on-CH_SWITCH.patch
> new file mode 100644
> index 000000000..43a167e4c
> --- /dev/null
> +++ b/0001-wpa_supplicant-Notify-freq-change-on-CH_SWITCH.patch
> @@ -0,0 +1,108 @@
^^ So, this should be gone too.
FWIW, I've reviewed the code, so other than the patching/formatting mixups:
Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>
Feel free to include that in your version 2.
Brian
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
