Re: [PATCH] wolfSSL TLS layer: Check NULL return from wolfSSL_sk_value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 25, 2020 at 12:01:10PM +1000, Sean Parkinson wrote:
> diff --git a/src/crypto/tls_wolfssl.c b/src/crypto/tls_wolfssl.c
> @@ -585,7 +585,7 @@ static int tls_match_alt_subject_component(WOLFSSL_X509 *cert, int type,
>  
>  	for (i = 0; ext && i < wolfSSL_sk_num(ext); i++) {
>  		gen = wolfSSL_sk_value(ext, i);
> -		if (gen->type != type)
> +		if (gen == NULL || gen->type != type)
>  			continue;
...

These were already covered by the earlier "Fix wrong types in
tls_wolfssl.c" patch (*), so I'm dropping this separate patch just for
the NULL checks.

(*) http://patchwork.ozlabs.org/project/hostap/patch/20200804094823.59816-1-juliusz@xxxxxxxxxxx/

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux