Re: [PATCH 6/6] bss coloring: handle the collision and CAC events coming from the kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 17.06.20 19:37, Shay Bar wrote:
Hi,
Few design questions:
1. Why should hostapd be involved in adding the cca IE ?
     Instead __ieee80211_beacon_get() can add it in mac80211/tx.c and update hostapd with the new color after CAC.
I basically followed the flow of how CSA does it.
Channel switch is invoked from user-space while collision will always be invoked from kernel.
Driver/mac80211 can handle the cca IE addition/counter and update hostapd with the new color when finish CAC.
This way, kernel can determine the initial color (random/fixed/scan/other method) and update hostapd at startup,
Later, upon collision handle all the change (including IE addition with counter) in kernel and update hostapd with the new color once done.

Let me look into that tomorrow

2. Currently, the initial BSS Color is taken from the hostapd.conf file.
     Don't you think it will be better to set it dynamically upon AP startup rather than take it from the conf file ?
I actually set a random value in hostapd.conf, however one can set a
static one if desired. having the kernel autogenerate this would not
allow explicit values to be set.
This is what I mean, we need option for randomness of the initial color inside hostapd/kernel code instead of fixed value from .conf

i implemented this inside openwrt like such

                he_bss_color=$(head -1 /dev/urandom | tr -dc '0-9' | head -c2)
                he_bss_color=$(($he_bss_color + 1))
                he_bss_color=$(($he_bss_color % 63))

but we could just make hostapd use a random if the option is not set in the .conf. fair point

3. Are you planning to add the "collision" and "color in use" event reports as well ?
these 2 exist inside the patchset, EVENT_BSS_COLOR_COLLISION and
EVENT_CCA_NOTIFY, latter being called along the lines of how CSA does it.
I was actually referring to the event report (action) frames being sent from STA to notify AP with "collision" color or "color in use".
________________________________

I assume you mean OBSS PD ? that is handled on ath11k inside the FW. the STA will automagically send the frame to the AP, which will then trigger the collision event, this already works with the patches i sent. IMHO ax200 does this fully in FW aswell and we do not need to manually generate nor parse the frames.

   John


_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux