On Mon, Jun 01, 2020 at 11:14:26PM -0700, Rajkumar Manoharan wrote: > Enable user to configure Maximum MPDU Length, Maximum A-MPDU Length > Exponent, Rx Antenna Pattern Consistency and Tx Antenna Pattern > Consistency of 6 GHz capability through config file. > diff --git a/hostapd/hostapd.conf b/hostapd/hostapd.conf > +# he_6ghz_capab: HE 6 GHz capabilities (list of flags) It sounds fine to make such capabilities configurable, but please split this into multiple configuration parameters just like all the other HE parameters are instead of using the difficult to use ht_capab/vht_capab style of a string with list of flags in them. > +# Maximum MPDU Length: [MAX-MPDU-LEN-7991] [MAX-MPDU-LEN-11454] > +# Indicates maximum MPDU length > +# 0 = 3895 octets (default) > +# 1 = 7991 octets > +# 2 = 11454 octets > +# 3 = reserved For example, this could be he_6gzh_max_mpdu. > +# Maximum A-MPDU Length Exponent: [MAX-AMPDU-LEN-EXP-8K]..[MAX-AMPDU-LEN-EXP-1024K] > +# Indicates the maximum length of A-MPDU pre-EOF padding that the STA can recv > +# This field is an integer in the range of 0 to 7. > +# The length defined by this field is equal to > +# 2 pow(13 + Maximum A-MPDU Length Exponent) -1 octets > +# > +# Rx Antenna Pattern Consistency: [RX-ANTENNA-PATTERN] > +# Indicates the possibility of Rx antenna pattern change > +# 0 = Rx antenna pattern might change during the lifetime of an association > +# 1 = Rx antenna pattern does not change during the lifetime of an association > +# > +# Tx Antenna Pattern Consistency: [TX-ANTENNA-PATTERN] > +# Indicates the possibility of Tx antenna pattern change > +# 0 = Tx antenna pattern might change during the lifetime of an association > +# 1 = Tx antenna pattern does not change during the lifetime of an association And similar separate parameters for these. Those 0/1 values for antenna patterns look strange in a list-of-flags description, but make sense for something like he_6ghz_tx_ant_pat. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
