On Wed, Mar 04, 2020 at 06:16:48PM +0100, Alexander Wetzel wrote: > This is the next attempt to migrate nl80211 to key_flag API. > The different fixes have been split up and reworked as discussed. > > All patches of the series are standalone patches with the exception of > the last one which requires most of the other fixes. > > I dropped two patches for now: > - Replace WPA_ALG_PMK with KEY_FLAG_PMK > - nl80211,wpa_supplicant: Drop outdated tdls hack > > and will resubmit them when nl80211 is using the key_flags. > > Alexander Wetzel (8): > ieee8021x: Fix unicast argument for set_wep_key() > AP: Don't try to set NULL WEP default key > key_flag API tuning and fixes > nl80211: Ignore seq number for key deletion > nl80211: Fix wrong return code in set_key error path > nl80211: Remove not needed netlink key attribute > nl80211: Don't ignore when SET_KEY returns ENOENT > nl80211: Migrate from set_tx to key_flag API Thanks, applied with some cleanup. I did split up that "key_flag API tuning and fixes" into couple of patches (whenever there is a potential question of should a patch be split to smaller pieces where such pieces could make sense on there own, the answer is almost always "yes"). The KEY_FLAG_PMK check in the last patch seemed to trigger a potentially confusing failure message in debug log, so I changed it to return 0 instead of an error code from set_key(). It is not really an error case for the driver not to indicate WPA_DRIVER_FLAGS_4WAY_HANDSHAKE_8021X capability. In theory, that check could be moved to the caller to avoid the call altogether, but I'm not sure that is really any cleaner than allowing the call to go through and set_key() handler simply deciding not to do anything. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
