Re: wds link and Radius authentication issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



consider my answer to you
have you tried to revert the patches i mentioned?

Sebastian

Am 03.03.2020 um 16:28 schrieb Cedric VONCKEN:
The origin of the issue is  in VLAN sta feature and  WDS sta feature management.
These both features are managed with the same code.

In case of we use a WDS sta and 802.1x authentication that don't work.
When the AP side receive the null function frame in 4addr format from the sta, hostapd create the sta netdev and call the NL message NL80211_CMD_SET_STATION. In mac80211 the function ieee80211_change_station assign the pointer vlansdata->u.vlan.sta.

During the 802.1x authentication hostapd send the NL80211_CMD_SET_STATION message for add vlan management. I didn't understand why hostapd require this call, because in the msg no vlan information is given. With this second call, ieee80211_change_station function, set the vlansdata->u.vlan.sta to NULL . After that no frames are sent through the wds sta netdev and all frame are sent with 3 addr.
In the sta side all frames received with 3 addr is droped if the sta is configured to use 4 addr header format.

So no IP communication is possible between the AP and the STA.

I tried to fix this issue, but I'm not sure where I should fix the issue (hostapd or mac80211).
Finally, I found a workaround, in hostapd if I disabled the VLAN feature the issue is fixed (because the second call is not present). For the moment I don't use this feature so I can disabled it.

I hope an mac80211/hostapd expert will fix this issue in next version.

Thinks for your help.
-----Message d'origine-----
De : Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Envoyé : mardi 3 mars 2020 10:31
À : Cedric VONCKEN <cedric.voncken@xxxxxxxxx>; Steve deRosier
<derosier@xxxxxxxxx>
Cc : linux-wireless@xxxxxxxxxxxxxxx
Objet : Re: [mac80211]: wds link and Radius authentication issue

Hi Cedric,

Umm, that was hard to read. You should quote my writing, not your own :)


The wlan0.sta1 net dev was created by hostapd to manage the wds sta.
This netdev type is AP VLAN. The function ieee80211_lookup_ra_sta
return -ENOLINK because the pointer sdata->u.vlan.sta was not
defined.
Right.

In mac80211, where this rcu pointer is allocated? Which NL message the
user space use ?

Look at ieee80211_change_station(), called from nl80211_set_station() with

	params.vlan = get_vlan(info, rdev);

johannes

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux