On Tue, Jan 28, 2020 at 03:54:29PM +0100, yegorslists@xxxxxxxxxxxxxx wrote: > Run autopep8 and changes some other warning manually. I'd be fine changes indentation to use spaces, but I'm not sure I want to open the door for running some automated tools to reformat all 125+k lines of python code in hostap.git since some of the other changes do not seem to match the style used in tests/hwsim/*.py. This type of changes are inconvenient to review manually, so there would need to be a separate commit for each change that I could execute myself without having to do such review. And in any case, there would need to be clear justification on doing something like this if it ends up generating thousands of modifications just to be closer to some definition of python formatting. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
