On Mon, Jan 13, 2020 at 03:58:31PM +0100, Markus Theil wrote: > This patch series adds rx control port support over nl80211. Control port > over nl80211 delivers all EAPOL and PREAUTH frames to userspace. This conflicts > with the current hostapd handling of pre-auth frames. Therefore, this feature > gets disabled for hostapd. Furthermore a pending kernel patch is necessary to > forward pre-auth frames from userspace (otherwise handled by Linux bridge code). Could you please rebase this to be for EAPOL frames only, i.e., without any dependencies on the previous series that added RSN preauthentication frames? That should remove this constraint on hostapd or that kernel patch. > The corresponding Linux patches for pre-auth support for hostapd are: > - nl80211: add src and dst mac attributes > - nl80211: use src and dst addr attribute for control port tx/rx I'm assuming neither of those would be needed for EAPOL frames. > Furthermore another kernel patch is needed, in order to avoid a deadlock: > - cfg80211: fix deadlocks in autodisconnect work Could you please clarify how this deadlock get triggered? Would that happen if hostapd or wpa_supplicant were now updated to use nl80211 control port for EAPOL RX? If so, this sounds problematic and potentially needing a workaround of some sort to avoid critical issues with kernel versions that do not have this fix. > This patch enables wpa_supplicant to use control port rx over nl80211 for both > EAPOL and PREAUTH frames. wpa_supplicant connects noticeably faster in my tests > with this patch series applied. That difference in connection speed is surely not related to RSN preauthentication frame handling, so if that kernel deadlock is not a significant problem, it would be good to get the EAPOL frame part included. > nl80211: use and/or set socker owner where necessary That's missing Signed-off-by: line in the commit message. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
