On Sat, Feb 15, 2020 at 11:02:50PM +0100, Didier 'OdyX' Raboud wrote: > I'm trying to get eapol_test built by default in Debian [0,1] and it seems > that some minor parts don't build in current Debian sid's GCC, so here comes a > quick patch to make these to correctly. They're just printf reformatting. > > Looking forward to integrate these in wpasupplicant! Thanks. What's the error (or warning?) from gcc that breaks this? > Fix printf calls for eapol_test build > > Origin: vendor > Author: Didier Raboud <odyx@xxxxxxxxxx> > Last-Update: 2020-02-15 Could you please read the top level CONTRIBUTIONS file (*) and provide a Signed-off-by: line for the commit message so that I can apply this? (*) http://w1.fi/cgit/hostap/plain/CONTRIBUTIONS > --- a/wpa_supplicant/wpa_supplicant.c > +++ b/wpa_supplicant/wpa_supplicant.c > - wpa_printf(MSG_DEBUG, "wpa_supplicant v" VERSION_STR); > + wpa_printf(MSG_DEBUG, "wpa_supplicant v%s", VERSION_STR); This looks strange.. VERSION_STR is a define for a string.. Has gcc really stopped allowing string constants from being concatenated in this manner? Sounds like an excessive approach for avoiding printf format issues.. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
