Re: [Regression] 4-way handshake offloading in wpa_supplicant 2.8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arend,

Am 01.07.19 um 09:52 schrieb Arend Van Spriel:
> On 6/29/2019 11:37 AM, Stefan Wahren wrote:
>
> ...
>
> Hi Stefan,
>
> I actually had another proposal, but was waiting for feedback from
> Jouni. So my idea was to introduce a separate flag for this offload as
> the req_key_mgmt_offload is for offload using different API, ie. a QCA
> vendor command. Below is the patch I prepared. Let me know if that
> works for you.
the patch below also fixes the issue. Thanks
>
> Regards,
> Arend
> ---
> diff --git a/src/drivers/driver.h b/src/drivers/driver.h
> index d0f449f..16b438f 100644
> --- a/src/drivers/driver.h
> +++ b/src/drivers/driver.h
> @@ -1067,6 +1067,14 @@ struct wpa_driver_associate_params {
>      int req_key_mgmt_offload;
>
>      /**
> +     * req_handshake_offload - Request EAPOL handshake offload
> +     *
> +     * Request EAPOL handshake offload for this connection if the device
> +     * supports it.
> +     */
> +    int req_handshake_offload;
> +
> +    /**
>       * Flag for indicating whether this association includes support for
>       * RRM (Radio Resource Measurements)
>       */
> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> index 45835a2..c44bd20 100644
> --- a/src/drivers/driver_nl80211.c
> +++ b/src/drivers/driver_nl80211.c
> @@ -5632,7 +5632,7 @@ static int nl80211_connect_common(struct
> wpa_driver_nl80211_data *drv,
>              return -1;
>      }
>
> -    if (params->req_key_mgmt_offload &&
> +    if (params->req_handshake_offload &&
>          (drv->capa.flags & WPA_DRIVER_FLAGS_4WAY_HANDSHAKE_8021X)) {
>              wpa_printf(MSG_DEBUG, "  * WANT_1X_4WAY_HS");
>              if (nla_put_flag(msg, NL80211_ATTR_WANT_1X_4WAY_HS))
> diff --git a/wpa_supplicant/wpa_supplicant.c
> b/wpa_supplicant/wpa_supplicant.c
> index 2002b12..0332d5a 100644
> --- a/wpa_supplicant/wpa_supplicant.c
> +++ b/wpa_supplicant/wpa_supplicant.c
> @@ -3224,7 +3224,7 @@ static void wpas_start_assoc_cb(struct
> wpa_radio_work *work, int deinit)
>           params.key_mgmt_suite == WPA_KEY_MGMT_IEEE8021X_SHA256 ||
>           params.key_mgmt_suite == WPA_KEY_MGMT_IEEE8021X_SUITE_B ||
>           params.key_mgmt_suite == WPA_KEY_MGMT_IEEE8021X_SUITE_B_192))
> -        params.req_key_mgmt_offload = 1;
> +        params.req_handshake_offload = 1;
>
>      if (wpa_s->conf->key_mgmt_offload) {
>          if (params.key_mgmt_suite == WPA_KEY_MGMT_IEEE8021X ||

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux