RE: [PATCH 1/6] AP: Add initial support for 6GHz band

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> > diff --git a/hostapd/hostapd.conf b/hostapd/hostapd.conf @@ -147,7
> > +147,8 @@ ssid=test  # Operation mode (a = IEEE 802.11a (5 GHz), b =
> > IEEE 802.11b (2.4 GHz),  # g = IEEE 802.11g (2.4 GHz), ad = IEEE
> > 802.11ad (60 GHz); a/g options are used  # with IEEE 802.11n (HT),
> > too, to specify band). For IEEE 802.11ac (VHT), this -# needs to be
> > set to hw_mode=a. When using ACS (see channel parameter), a
> > +# needs to be set to hw_mode=a. For IEEE 802.11ax (HE) on 6-7 GHz
> > +this needs # to be set to hw_mode=ax. When using ACS (see channel
> > +parameter), a
> 
> This feels pretty confusing. Why would hw_mode=ax be used for the 6 GHz band
> while all other cases of 802.11ax would not use hw_mode=ax? I'd much rather
> continue using hw_mode=a for these and instead of trying to encode the band
> somehow in the not exactly clear hw_mode, add a new configuration parameter
> op_class that takes the global operating class number (Table E-4 in the standard)
> to get the op_class,channel pair to define the channel.

It makes sense. I'll change it to use operating classes instead.

> 
> >  # HE operating channel information; see matching vht_* parameters for
> details.
> > +# On 6GHz band (hw_mode=ax) the center freq calculation starts from 5.940
> offset.
> > +# For example idx=3 would result in 5955MHz center frequency. In
> > +addition, # he_oper_chwidth is ignored, and the channel width is
> > +derived from the # configured center frequencies (See
> > +IEEE802.11ax/D4.1 Annex E)
> 
> The bandwidth should really be from the op_class,channel pair, not center
> frequency, so this is yet another justification for adding op_class instead of trying
> to extend hw_mode.
> 
> > diff --git a/src/ap/hw_features.c b/src/ap/hw_features.c @@ -158,6
> > +158,7 @@ int hostapd_prepare_rates(struct hostapd_iface *iface,
> >  	else switch (mode->mode) {
> >  	case HOSTAPD_MODE_IEEE80211A:
> > +	case HOSTAPD_MODE_IEEE80211AX: /* same as 5GHz */
> 
> Just like this type of cases where hw_mode=a would really be usable as-is.

Ok.. I'll submit an updated version

Andrei
> 
> --
> Jouni Malinen                                            PGP id EFC895FA
> 
> _______________________________________________
> Hostap mailing list
> Hostap@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/hostap

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux