Re: [PATCH] nl80211: Remove unreachable code in add_ifidx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 03, 2019 at 03:16:13PM +0300, Andrei Otcheretianski wrote:
> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> @@ -6658,12 +6658,7 @@ static void add_ifidx(struct wpa_driver_nl80211_data *drv, int ifidx,
>  		else
>  			drv->if_indices_reason = old_reason;
>  	}
> -	if (!drv->if_indices || !drv->if_indices_reason) {
> -		wpa_printf(MSG_ERROR, "Failed to reallocate memory for "
> -			   "interfaces");
> -		wpa_printf(MSG_ERROR, "Ignoring EAPOL on interface %d", ifidx);
> -		return;
> -	}
> +
>  	if (!old)
>  		os_memcpy(drv->if_indices, drv->default_if_indices,
>  			  sizeof(drv->default_if_indices));

This is hiding the real issue, i.e., the reason why this code became
unreachable. I'll drop this patch and fix that real issue instead.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux