On Mon, Apr 22, 2019 at 5:42 PM Dan Williams <dcbw@xxxxxxxxxx> wrote: > > On Mon, 2019-04-22 at 15:58 -0700, Eric Caruso wrote: > > Add two D-Bus methods: > > * EnableMACAddressRandomization: (ay : mask) -> nothing > > * DisableMACAddressRandomization: nothing -> nothing > > I'd almost rather see a single method call, like > SetMACAddressRandomization(ay : mask) -> nothing where a zero-length > mask means disabling randomization (since it appears a mask is > required?) > > But also, is a mask really required? Can't we just pick a suitable > default (and allow len(mask)==0) and only if the user wants a different > behavior, then they have to pass a full mask? I'm afraid I don't really understand what you mean here. Are you suggesting a single method with three possible effects, where a 6-byte mask enables randomization with that mask exactly, a 0-length mask enables randomization with a default mask (say, keeping the OUI and randomizing the rest), and no argument to disable randomization? I think this sort of API design makes it really hard to understand what's going on and how to use it correctly, personally... > > Dan _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
