Re: [PATCH] EAP: Remove unreachable code in EAP auth SM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 03, 2019 at 03:16:12PM +0300, Andrei Otcheretianski wrote:
> diff --git a/src/ap/wpa_auth.c b/src/ap/wpa_auth.c
> @@ -3302,16 +3302,9 @@ SM_STATE(WPA_PTK, PTKINITDONE)

> -	if (0 /* IBSS == TRUE */) {
> -		sm->keycount++;
> -		if (sm->keycount == 2) {
> -			wpa_auth_set_eapol(sm->wpa_auth, sm->addr,
> -					   WPA_EAPOL_portValid, 1);
> -		}
> -	} else {
> -		wpa_auth_set_eapol(sm->wpa_auth, sm->addr, WPA_EAPOL_portValid,
> -				   1);
> -	}
> +	wpa_auth_set_eapol(sm->wpa_auth, sm->addr, WPA_EAPOL_portValid,
> +			   1);
> +

Why? That IBSS case is documented there for purpose as a reminder for
eventually completing that behavior as defined in the standard.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux