Re: [PATCH] HE: set field to 1023 if no he_rts_threshold is set in the configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 26/03/2019 12:41, John Crispin wrote:
"9.4.2.243 HE Operation element" states that when no RTS threshold is
set, the field should be set to 1023. This patch extends the if clause
to do just that.

Signed-off-by: John Crispin <john@xxxxxxxxxxx>
---
  src/ap/ieee802_11_he.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/src/ap/ieee802_11_he.c b/src/ap/ieee802_11_he.c
index 33f1ed14e..e940312cf 100644
--- a/src/ap/ieee802_11_he.c
+++ b/src/ap/ieee802_11_he.c
@@ -76,6 +76,9 @@ u8 * hostapd_eid_he_operation(struct hostapd_data *hapd, u8 *eid)
  		oper->he_oper_params |=
  			(hapd->iface->conf->he_op.he_rts_threshold <<
  			 HE_OPERATION_RTS_THRESHOLD_OFFSET);
+	else
+		oper->he_oper_params |=
+			HE_OPERATION_RTS_THRESHOLD_MASK;
if (hapd->iface->conf->he_op.he_bss_color)
  		oper->he_oper_params |=

Hi,

please dont apply this, its better to set he_rts_threshold to 1023 inside config_file.c if the parameter is not passed inside the conf file, as 0 is actually a valid value for the element.

I'll send a V2 shortly.

    John


_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux