Re: wpa_supplicant-2.7 fails to compile if IEEE80211R is enabled and FILS is not

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 15, 2019 at 11:03 AM Neeraj Poojary <npoojary@xxxxxxxxxxxx> wrote:
>
>
> $ diff -u defconfig .config
> --- defconfig   2018-12-02 11:34:59.000000000 -0800
> +++ .config     2019-03-15 10:47:01.356829103 -0700
> @@ -382,7 +382,7 @@
>  #CONFIG_DYNAMIC_EAP_METHODS=y
>
>  # IEEE Std 802.11r-2008 (Fast BSS Transition) for station mode
> -#CONFIG_IEEE80211R=y
> +CONFIG_IEEE80211R=y
>
>  # Add support for writing debug log to a file (/tmp/wpa_supplicant-log-#.txt)
>  #CONFIG_DEBUG_FILE=y
>
>
> make fails with...
> sme.c: In function ‘sme_associate’:
> sme.c:1609:3: warning: implicit declaration of function ‘remove_ie’; did you mean ‘remove’? [-Wimplicit-function-declaration]
>    remove_ie(wpa_s->sme.assoc_req_ie,

Looks like that was already addressed post-release:

commit f2973fa39d6109f0f34969e91551a98dc340d537
Author: Jouni Malinen <j@xxxxx>
Date:   Mon Dec 3 12:00:26 2018 +0200

    FT: Fix CONFIG_IEEE80211X=y build without CONFIG_FILS=y

    remove_ie() was defined within an ifdef CONFIG_FILS block while it is
    now needed even without CONFIG_FILS=y. Remove the CONFIG_FILS condition
    there.

    Fixes 8c41734e5de1 ("FT: Fix Reassociation Request IEs during FT protocol")
    Signed-off-by: Jouni Malinen <j@xxxxx>

Perhaps this suggests people shouldn't be using FILS *or* FT support :)

Brian

> It looks like definition of remove_ie() is wrapped in CONFIG_FILS, but usage is not. Is there an expectation that FILS should be enabled if we're using 80211R? At the same time, the description for CONFIG_FILS says 'This is an experimental and not yet complete implementation. This
> should not be enabled for production use.'

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux