Re: [PATCH 05/18] defconfig: enable DBus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2019-02-25 at 19:21 +0200, Jouni Malinen wrote:
> On Tue, Feb 19, 2019 at 02:44:08PM +0100, Lubomir Rintel wrote:
> > Acquire both legacy and new name, along with introspection. This is
> > generally useful for other daemons to integrate with wpa_supplicant,
> > notably NetworkManager.
> > 
> > Debian and Fedora (and likely any other distro that configured wireless
> > via NetworkManager) enable this.
> >  # Add support for old DBus control interface
> >  # (fi.epitest.hostap.WPASupplicant)
> > -#CONFIG_CTRL_IFACE_DBUS=y
> > +CONFIG_CTRL_IFACE_DBUS=y
> 
> Why would this obsolete old interface be needed? I'd much rather remove
> this completely than promote it by enabling it in more builds..

Agreed. According to searchcode [1] not much more than 2010's
NetworkManager 0.8 uses this. Pretty sure it's safe to remove it.

[1] https://searchcode.com/?q=%22fi.epitest.hostap.WPASupplicant%22

I'll follow up with a patch that does the removal.

> >  # Add support for new DBus control interface
> >  # (fi.w1.hostap.wpa_supplicant1)
> > -#CONFIG_CTRL_IFACE_DBUS_NEW=y
> > +CONFIG_CTRL_IFACE_DBUS_NEW=y
> >  
> >  # Add introspection support for new DBus control interface
> > -#CONFIG_CTRL_IFACE_DBUS_INTRO=y
> > +CONFIG_CTRL_IFACE_DBUS_INTRO=y
> 
> These make sense, though, and I'd hope all current programs would use
> the new D-Bus interface since the old one is not really maintained
> anymore and is considered obsolete.

Lubo


_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux