Re: [PATCH 1/5] common: add strongly typed element iteration macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 08, 2019 at 05:57:48PM +0100, Johannes Berg wrote:
> Rather than always iterating elements from frames with pure
> u8 pointers, add a type "struct element" that encapsulates
> the id/datalen/data format of them.
> 
> Then, add the element iteration macros
>  * for_each_element
>  * for_each_element_id
>  * for_each_element_extid

Thanks, all five patches applied with some cleanup. In particular, I
tried to avoid unnecessary typecasting from const pointer to non-const
pointers and also to enforce that the first argument is of the correct
type (and not just contain correctly named variables). There was also a
signed/unsigned comparison which is now gone with a typecast. And one of
the followup patches using the macros ended up dropping an explicit
check for the pointer to the beginning of IEs being NULL, so I restored
that just in case the function could actually be called with a NULL
pointer.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux