Re: [PATCH 31/50] tests: Modify kernel test sets for python3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2019-01-24 at 16:46 +0900, Masashi Honma wrote:
> Signed-off-by: Masashi Honma <masashi.honma@xxxxxxxxx>
> ---
>  tests/hwsim/test_kernel.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/hwsim/test_kernel.py b/tests/hwsim/test_kernel.py
> index f2b072300..0427b73bc 100644
> --- a/tests/hwsim/test_kernel.py
> +++ b/tests/hwsim/test_kernel.py
> @@ -34,12 +34,12 @@ def _test_kernel_bss_leak(dev, apdev, deauth):
>                      'sa': pkt['da'],
>                      'da': pkt['sa'],
>                      'bssid': pkt['bssid'],
> -                    'payload': '\x01\x00',
> +                    'payload': b'\x01\x00',
>                  })
>              break
>          else:
>              hapd.request("MGMT_RX_PROCESS freq=2412 datarate=0 ssi_signal=-30 frame=%s" % (
> -                         binascii.hexlify(pkt['frame']), ))
> +                         binascii.hexlify(pkt['frame']).decode(), ))
> 

Same here, we could just have hapd.request() take bytes (it makes sense
anyway when communicating with another process!) and then the .decode()
isn't needed, you just have to add a b"" to the string.

johannes


_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux