On Wed, Jan 09, 2019 at 01:34:11PM +0100, Arnout Vandecappelle (Essensium/Mind) wrote: > Since 3bdc651a624, start.sh creates the logs/current symlink even if > LOGDIR was set in the environment, as is the case when using run-all.sh. > However, run-all.sh and start.sh use a separate 'date' invocation so the > resulting string may be different. Usually it is the same because the > two invocations immediately follow each other, *except* if run-all.sh > also does a build. In addition, if the user sets LOGDIR to something > else, the symlink is completely bogus. > > Fix this by not relying on the 'date' invocation for creating the > symlink. Instead, use the basename of LOGDIR. To keep things consistent > with current behavior, only create the symlink if LOGDIR points to a > subdirectory of DIR/logs. > > The following use cases now work reliably: > * run-all.sh with or without the -B option; > * manually calling start.sh followed by run-tests.py without setting > LOGDIR. > * manually calling start.sh with LOGDIR set to a subdirectory of logs > and calling run-tests.py without --logdir option (which makes it > default to logs/current). > * run-all.sh with LOGDIR set to a subdirectory of logs. Thanks, applied. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
