Re: [PATCH 1/2] drivers: add separate driver flags for 802.1X and WPA/WPA2-Personal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 07, 2019 at 12:14:40PM +0100, Arend van Spriel wrote:
> Allow drivers to indicate support for either 802.1X and/or WPA/WPA2-PSK
> introducing two separate drivers flags.

Thanks, applied.

> diff --git a/src/drivers/driver_wext.c b/src/drivers/driver_wext.c

>  		if (range->enc_capa & IW_ENC_CAPA_4WAY_HANDSHAKE)
> -			drv->capa.flags |= WPA_DRIVER_FLAGS_4WAY_HANDSHAKE;
> +			drv->capa.flags |= (WPA_DRIVER_FLAGS_4WAY_HANDSHAKE_PSK |
> +					    WPA_DRIVER_FLAGS_4WAY_HANDSHAKE_8021X);

> @@ -1678,7 +1679,7 @@ static int wpa_driver_wext_set_psk(struct wpa_driver_wext_data *drv,
>  
>  	wpa_printf(MSG_DEBUG, "%s", __FUNCTION__);
>  
> -	if (!(drv->capa.flags & WPA_DRIVER_FLAGS_4WAY_HANDSHAKE))
> +	if (!(drv->capa.flags & WPA_DRIVER_FLAGS_4WAY_HANDSHAKE_8021X))
>  		return 0;
>  
>  	if (!psk)

I could not make sense out of this, i.e., whether it should be PSK or
8021X or either, but since both flags are set now in capa.flags, it does
not really make sense and I did not want to think more about WEXT, so I
decided not to care enough.. ;-)

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux