Re: [PATCH v8 08/16] mesh: update ssid->frequency as pri/sec channel switch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 27, 2018 at 02:28:41PM -0700, peter.oh@xxxxxxxxxxxxxxxxx wrote:
> ssid->frequency is one of variables used to gets channel
> number from given frequency. Leave it as unchanged when
> pri/sec channel switched will cause picking up wrong
> channel number after applying secondary channel offset
> for HT40 and leads failing interface bring-up.

> diff --git a/wpa_supplicant/mesh.c b/wpa_supplicant/mesh.c
> @@ -285,6 +285,7 @@ static int wpa_supplicant_mesh_init(struct wpa_supplicant *wpa_s,
>  	    frequency == freq->freq + freq->sec_channel_offset * 20) {
>  		wpa_printf(MSG_DEBUG, "mesh: pri/sec channels switched");
>  		frequency = freq->freq;
> +		ssid->frequency = frequency;

This does not look like the correct thing to do since this would end up
changing the stored network profile. I would simply drop this patch and
leave this to the workaround I applied with moving of
wpa_supplicant_conf_ap_ht() (i.e., change ssid->frequency only
temporarily during that call).

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux