On 23/12/2018 16:37, Jouni Malinen wrote: > On Sun, Oct 07, 2018 at 02:31:51PM +0200, Andrej Shadura wrote: >> Make it possible to list connected stations in AP mode over D-Bus, along >> with some of their properties: rx/tx packets, bytes, capabilities, etc. >> >> Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@xxxxxxxxxxxxx> >> >> Rebased by Julian Andres Klode <juliank@xxxxxxxxxx> and updated to use >> the new getter API. >> >> Further modified by Andrej Shadura to not error out when not in AP mode >> and to send separate StationAdded/StationRemoved signals instead of >> changing signatures of existing StaAuthorized/StaDeauthorized signals. >> >> Signed-off-by: Andrej Shadura <andrew.shadura@xxxxxxxxxxxxxxx> > > Thanks, applied with fixes and cleanup. I just wonder how this was > tested since this trigger a segmentation fault on first station > connection and even with that fixed, the signals were swapped > (StationRemove indicated when the station was added).. > > I removed indication of sta->flags since those WLAN_STA_* values are > internal to hostapd implementation and subject to change without notice. > In other words, they are not appropriate to expose over a D-Bus > interface to external programs. If some of those flags are needed for > external use, those specific flags should be exported separately and > using values that are not implementation specific. I’m sorry for the mess, apparently I broke things during the last rewrite or rebase, not sure. I probably should have paid more attention to testing what I’m sending out — now seeing that you’ve actually included those signals in the tests, I should have done that myself since the beginning. Thanks for cleaning up and fixing it. -- Cheers, Andrej _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
